Update smithay with layer shell updates #1726
Conversation
ids1024
force-pushed
the
smithay-layer-shell_noble
branch
3 times, most recently
from
8834505 to
6b28e33
Compare
|
Reading though the relevant |
ids1024
force-pushed
the
smithay-layer-shell_noble
branch
from
6b28e33 to
60509a6
Compare
|
This should fix pop-os/cosmic-epoch#2199, though that appears to be an inconsistent race condition that may not be easily reproducible. The layer |
ids1024
changed the title
| .last_acked | ||
| .as_ref() | ||
| .is_some_and(|configure| configure.state.size == current_server.size) | ||
| { |
There was a problem hiding this comment.
Can't we simplify this whole thing with the new with_committed_state helper or am I misunderstanding how that works internally? Seems to me, that we don't need to manually check the ack'd serial.
There was a problem hiding this comment.
Yeah, I guess with_committed_state() would work here; though we also use states.data_map, in addition to the states.cached_state, to get the current_server_state().
I guess it wouldn't really be a problem to take the with_states lock twice (but not at the same time) here? Though it might not simplify things much.
Reduces a bit of duplication.
Updates for `last_acked`, etc. API changes in Smithay/smithay#1817. Includes layer shell fixes from Smithay/smithay#1819.
ids1024
force-pushed
the
smithay-layer-shell_noble
branch
from
60509a6 to
c30e3d5
Compare
|
Rebased and updated to smithay commit including fix in Smithay/smithay#1853. |
Update to smithay from Smithay/smithay#1819.
Some changes are needed to adapt to Smithay/smithay#1817. Even after looking at the changes there, I'm not entirely sure how the replace
configure_serialandcurrent_serial...